Integrated: 8331348: Some incremental builds deposit files in the make directory

Nizar Benalla nbenalla at openjdk.org
Thu May 23 16:07:11 UTC 2024


On Wed, 22 May 2024 00:33:44 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

> Please review this small change. Passes tier 1-3.
> 
> In case of fatal errors or if a hidden option is passed to the compiler, a report with the parameters passed to it is printed to a file in the `@-file` format, this makes it easier for us to reproduce the bug. And for users submitting bug reports.
> Some of these files were being deposited in the current directory during OpenJDK builds, now they are moved to the temp dir.
> Writing to the console only is not an option because of the large number of arguments that can be passed to the compiler.
> By convention, a number of arguments is printed to the console if an error occurs while writing to the file.
> Some also suggested adding a message as to why this file exist.
> 
> TIA
> 
> I see the bot is complaining due to the fix version but I think it can be changed, if this is approved.

This pull request has now been integrated.

Changeset: 417d174a
Author:    Nizar Benalla <nbenalla at openjdk.org>
Committer: Magnus Ihse Bursie <ihse at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/417d174aa1b7bd3b5755e5f2352d9bbe6ce6f183
Stats:     4 lines in 1 file changed: 1 ins; 0 del; 3 mod

8331348: Some incremental builds deposit files in the make directory

Reviewed-by: ihse, vromero

-------------

PR: https://git.openjdk.org/jdk/pull/19338


More information about the compiler-dev mailing list