RFR: 8332226: "Invalid package name:" from source launcher [v2]

[Christian Stein]

On Tue, 21 May 2024 19:29:27 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Even with `exports jdk.internal.module to jdk.compiler` already in place before this change?
>> 
>> https://github.com/openjdk/jdk/blob/52eda79522a5bd71b527e5946b654a331b021473/src/java.base/share/classes/module-info.java#L227-L231
>
>> Even with `exports jdk.internal.module to jdk.compiler` already in place before this change?
> 
> We can't have code in jdk.compiler that is compiled with both N-1 and N making use of classes in that internal package. So I think that will need to be fixed, for another PR of course, but let's not make it worse here.

Reverted the second commit; back to use `javax.lang.model.SourceVersion` in order to test for valid package name elemnts.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19245#discussion_r1613063516