RFR: 8332497: javac prints an AssertionError when annotation processing runs on program with module imports [v16]

[Evemose]

On Thu, 23 May 2024 11:12:32 GMT, Evemose <duke at openjdk.org> wrote:

>> Fix is pretty simple: visitModuleImport in com.sun.tools.javac.tree.TreeScanner has notbeen overriden, so defaulted to Visitor::visitModuleImport, which forwards to Visitor::visitTree, which is also not overriden, and, therefore, threw AssertionError. 
>> 
>> PS: Im not even sure how it worked before without crashing, seems like there is some intermidiate implementation between this TreeScanner and actual scanners because otherwise it should have resultedin compile error the moment it encounter module importin any visitor
>
> Evemose has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'origin/fix_module_imoprts_apt_fail' into fix_module_imoprts_apt_fail
>    
>    # Conflicts:
>    #	test/langtools/tools/javac/processing/ModuleImportProcessingTest.java
>  - moved test to processing folder

Do I have to somehow request review or just wait untill someone eventually does it?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19292#issuecomment-2128958264