RFR: 8332497: javac prints an AssertionError when annotation processing runs on program with module imports [v16]

[Evemose]

On Fri, 24 May 2024 13:49:28 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Evemose has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Merge remote-tracking branch 'origin/fix_module_imoprts_apt_fail' into fix_module_imoprts_apt_fail
>>    
>>    # Conflicts:
>>    #	test/langtools/tools/javac/processing/ModuleImportProcessingTest.java
>>  - moved test to processing folder
>
> test/langtools/tools/javac/processing/ModuleImportProcessingTest.java line 84:
> 
>> 82:                         "-processor", AP.class.getName(),
>> 83:                         "--enable-preview",
>> 84:                         "--source", System.getProperty("java.specification.version")
> 
> looking good, just a minor comment, here we usually use: `Integer.toString(Runtime.version().feature())` to get the source version, and for indentation we use 4 spaces

Im not sure about which indentaion you are talking here. You mean I should use whitespaces instead of tabs, or that I should add spaces betweeen some elements of the code?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19292#discussion_r1613690298