RFR: 8332890: Module imports don't work inside the same module
Vicente Romero
vromero at openjdk.org
Sat May 25 11:00:01 UTC 2024
On Fri, 24 May 2024 16:04:44 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:
> Consider a module descriptor like:
>
> import module m;
> module m {
> exports api;
> }
>
>
> javac will complain `m` does not read `m`:
>
> $ javac --enable-preview --source 23 module-info.java api/Api.java
> module-info.java:1: error: module m does not read: m
> import module m;
> ^
> Note: module-info.java uses preview features of Java SE 23.
> Note: Recompile with -Xlint:preview for details.
> 1 error
>
>
> But, readability is reflexive. The proposed solution is to simply include every module in its own readability set.
>
> As a side fix, `env.toplevel.packge.modle` does not work for `module-info`, `env.toplevel.modle` should be used instead.
lgtm
-------------
Marked as reviewed by vromero (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19398#pullrequestreview-2078923780
More information about the compiler-dev
mailing list