RFR: 8332497: javac prints an AssertionError when annotation processing runs on program with module imports [v19]

[Jan Lahoda]

On Sat, 25 May 2024 05:52:26 GMT, Evemose <duke at openjdk.org> wrote:

>> Fix is pretty simple: visitModuleImport in com.sun.tools.javac.tree.TreeScanner has notbeen overriden, so defaulted to Visitor::visitModuleImport, which forwards to Visitor::visitTree, which is also not overriden, and, therefore, threw AssertionError. 
>> 
>> PS: Im not even sure how it worked before without crashing, seems like there is some intermidiate implementation between this TreeScanner and actual scanners because otherwise it should have resultedin compile error the moment it encounter module importin any visitor
>
> Evemose has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Addressed review (2)
>  - Addressed review

Looks good to me. Thanks for working on this!

I am running tests now.

@Evemose, please note you'll need to type:


in a separate comment, so that a committer can sponsor.

Thanks!

-------------

Marked as reviewed by jlahoda (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19292#pullrequestreview-2080042442