RFR: 8332507: compilation result depends on compilation order [v5]

Vicente Romero vromero at openjdk.org
Fri May 31 14:54:15 UTC 2024


On Fri, 31 May 2024 14:29:52 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Vicente Romero has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comments
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassReader.java line 639:
> 
>> 637:                         @Override
>> 638:                         public List<Type> getTypeArguments() {
>> 639:                             List<Type> formalsCp = ((ClassType)t.type.tsym.type).typarams_field;
> 
> This works. You might use another boolean flag up top to say whether you actually need to adjust the type arguments (which is only needed the first time) ?

sure sorry I forgot about that, done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19400#discussion_r1622542255


More information about the compiler-dev mailing list