RFR: 8343306: javac is failing to determine if a class and a sealed interface are disjoint [v4]
Vicente Romero
vromero at openjdk.org
Fri Nov 1 14:59:28 UTC 2024
On Fri, 1 Nov 2024 13:46:32 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:
>> Vicente Romero has updated the pull request incrementally with one additional commit since the last revision:
>>
>> addressing review comments
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java line 1701:
>
>> 1699: }
>> 1700: }
>> 1701: } else if (!ts.isInterface() && // case II: both are classes
>
> Nit: it is not necessary to check both `ts` and `ss` (although it is not wrong). If one of them is a class, both are. For your consideration.
not sure, what if both are interfaces at this point in the code?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21794#discussion_r1825919524
More information about the compiler-dev
mailing list