RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v3]
Alexey Ivanov
aivanov at openjdk.org
Fri Nov 1 19:17:12 UTC 2024
On Thu, 24 Oct 2024 20:57:50 GMT, Sean Mullan <mullan at openjdk.org> wrote:
>> @honkar-jdk I'm inclined to leave it as because it's not the only method which doesn't have a blank line between `@param` and `@throw` in this file.
>>
>> If it's worth taking care of, we may submit another bug to address it later.
>
> This does not need to be handled in this PR. In the majority of changes, we have really tried hard to avoid making unrelated changes, but sometimes a few snuck in, like moving package imports or perhaps fixing a typo here and there that was not specific to JEP 486. My opinion is that unless it is something that _really_ should be done as part of a more general technical debt or code cleanup exercise, then it is ok to let a few of these in and they don't have to be reverted.
> > Can we add a blank line here? It's present in the methods above.
> >
> > Although there are other places below where it's missing; _so not worth worrying_.
>
> … it's not the only method which doesn't have a blank line between `@param` and `@throw` in this file.
>
> If it's worth taking care of, we may submit another bug to address it later.
I've submitted [JDK-8343448](https://bugs.openjdk.org/browse/JDK-8343448): _Improve formatting of docs in java.awt.Desktop_.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1826079117
More information about the compiler-dev
mailing list