RFR: 8343412: Missing escapes for single quote marks in javac.properties [v2]

Vicente Romero vromero at openjdk.org
Sat Nov 2 02:06:28 UTC 2024


On Fri, 1 Nov 2024 21:51:41 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

>> Please review these simple syntax fixes for `javac.properties`.
>> 
>> The source file `javac.properties` contains the English message bundle for the javac tool. Since the strings in this file are `MessageFormat` format strings, any single quotes must be escaped by doubling them.
>
> Archie Cobbs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Reword to keep width under 80 columns.

looks good

-------------

Marked as reviewed by vromero (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21816#pullrequestreview-2411118350


More information about the compiler-dev mailing list