RFR: 8342967: Lambda deduplication fails with non-metafactory BSMs and mismatched local variables names [v5]

[Vicente Romero]

On Thu, 31 Oct 2024 17:49:03 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

> > corpus jobs finished, mostly same results for both jobs one with and one without this patch. Of a total of ~23940 lambdas, none of them were deduplicated. This is a bit surprising tbh. It could be that most artifacts (all?) are generated with debug information. But still it seems like the benefit of this feature is marginal
> 
> Maybe not so surprising. I believe the default for javac is `-g:lines`, which disables the de-duplication. So, to see de-duplication, it would actually require the builds to explicitly use `-g:none`, which is probably not very common.

correct. I reran the corpus job. All lambdas (23948) are failing because of the use of debug options. Can we conclude after this that deduplication can be removed?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21687#issuecomment-2455033203