RFR: 8333427: langtools/tools/javac/newlines/NewLineTest.java is failing on Japanese Windows

Jonathan Gibbons jjg at openjdk.org
Wed Nov 6 00:51:28 UTC 2024


On Mon, 3 Jun 2024 11:42:08 GMT, KIRIYAMA Takuya <duke at openjdk.org> wrote:

> I fixed to get Charset from native.encoding instead of Charset.defaultCharset() when reading a file to which the output of javac run in the test was redirected.
> The modified code is based on the alternatives given in JEP400.
> I verified that the test passed on Windows in both Japanese and English locales with this fix.

Marked as reviewed by jjg (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/19519#pullrequestreview-2417049901


More information about the compiler-dev mailing list