RFR: 8333427: langtools/tools/javac/newlines/NewLineTest.java is failing on Japanese Windows [v2]

Jaikiran Pai jpai at openjdk.org
Wed Nov 6 05:41:50 UTC 2024


On Wed, 6 Nov 2024 01:23:31 GMT, KIRIYAMA Takuya <duke at openjdk.org> wrote:

>> I fixed to get Charset from native.encoding instead of Charset.defaultCharset() when reading a file to which the output of javac run in the test was redirected.
>> The modified code is based on the alternatives given in JEP400.
>> I verified that the test passed on Windows in both Japanese and English locales with this fix.
>
> KIRIYAMA Takuya has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update full name

Jon has approved the PR and I ran this change against our CI for tier1 and that passed. I'll go ahead and sponsor this now.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19519#issuecomment-2458763156


More information about the compiler-dev mailing list