RFR: 8341399: Add since checker tests to the langtools modules [v6]

Vicente Romero vromero at openjdk.org
Thu Nov 7 12:03:43 UTC 2024


On Mon, 4 Nov 2024 18:30:50 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> Can I get a review for this patch that adds `@since` checker tests to the following modules: java.compiler, jdk.compiler, jdk.javadoc and jdk.jdeps. The initial test for `java.base` has been integrated in [JDK-8331051](https://bugs.openjdk.org/browse/JDK-8331051). 
>> 
>> The jtreg comments are almost the same as the ones for the `java.base` test, only the Bug ID and the module name being passed to the test are different.
>> 
>> I've made a small change to `test/jdk/TEST.groups` to include the new tests.
>> 
>> Here are the emails  [[1](https://mail.openjdk.org/pipermail/jdk-dev/2024-June/009160.html)] [[2](https://mail.openjdk.org/pipermail/jdk-dev/2024-October/009474.html)] in `jdk-dev` describing how the tests work and how to run them.
>> 
>> TIA
>
> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
> 
>   tiny change in test summary

lgtm

-------------

Marked as reviewed by vromero (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21542#pullrequestreview-2420781852


More information about the compiler-dev mailing list