Proposal: Warnings for unnecessary warning suppression

[Archie Cobbs]

On Mon, Nov 11, 2024 at 8:58 AM Maurizio Cimadamore <
maurizio.cimadamore at oracle.com> wrote:

> Should I create issues for the following? Let me know your thoughts:
>
>    - Minor lint refactoring cleanups
>    - Add a new warn() compiler step after flow analysis
>       - ThisEscapeAnalyzer is a charter member
>       - Refactor to move lint warnings into the warn() step (umbrella)
>       - Add issues over time under this umbrella for migrating existing
>       warnings
>       - Depends on: Add new warn() step
>    - Umbrella issue for the @SuppressWarnings cleanup
>       - Existing cleanup issues go under here
>       - Suppression warnings (this proposal)
>       - Depends on: Add new warn() step
>       - Depends on: Umbrella issue for the @SuppressWarnings cleanup
>       - Depends on: Minor lint refactoring cleanups
>
> Yep. Not sure whether this proposal depends on the @SuppressWarnings
> cleanup: in principle you could also add the analysis and disable it when
> building the JDK, and let the various components to be updated at their
> pace.
>
Thanks. Here are the issues I've created...

Minor lint refactoring cleanups


JDK-8344079: Minor fixes and cleanups to compiler lint-related code

Add a new warn() compiler step after flow analysis


JDK-8344148: Add an explicit compiler phase for warning generation

Refactor to move lint warnings into the warn() step (umbrella)


I figured this one can come later.

 Umbrella issue for the @SuppressWarnings cleanup


JDK-8344076: Remove unnecessary @SuppressWarnings annotations and
Xlint:-foo options (umbrella)

Suppression warnings (this proposal)


JDK-8344159: Add lint warnings for unnecessary warning suppression

There are also PR's for the first two.

Thanks,
-Archie

-- 
Archie L. Cobbs
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/compiler-dev/attachments/20241113/f62466a7/attachment-0001.htm>