RFR: 8174840: Elements.overrides does not check the return type of the methods

Joe Darcy darcy at openjdk.org
Wed Nov 20 06:01:14 UTC 2024


On Tue, 19 Nov 2024 16:08:18 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

> Please review this essentially doc only change.

src/java.compiler/share/classes/javax/lang/model/util/Elements.java line 790:

> 788:      * requirements might not be checked, potentially causing this method
> 789:      * to return a false positive.
> 790:      *

The gist of this paragraph is good; some refinement is needed to not imply any particular requirements on the implementation, something like :"An implementation [of annotation processing] may choose to not check the additional requirements [under some limited conditions]".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22244#discussion_r1849591890


More information about the compiler-dev mailing list