RFR: 8174840: Elements.overrides does not check the return type of the methods [v2]

Pavel Rappo prappo at openjdk.org
Wed Nov 20 12:57:25 UTC 2024


On Wed, 20 Nov 2024 05:37:41 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> Pavel Rappo has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Respond to feedback
>>   
>>    - Reduce the number of files
>>    - Rephrase apiNote
>
> test/langtools/tools/javac/processing/model/util/elements/overrides/S.java line 24:
> 
>> 22:  */
>> 23: 
>> 24: public class S {
> 
> If all these testing types could be put into the single test file, that would be preferable.

I condensed all the testing types in just one file. I couldn't put them further, in `TestOverrides.java` itself, because they would make it non-compilable. Additionally, I removed `public` from `class S` for symmetry: it shouldn't be special.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22244#discussion_r1850268703


More information about the compiler-dev mailing list