RFR: 8338981: Access to private classes should be permitted inside the permits clause of the enclosing top-level class [v8]

[Evemose]

On Fri, 4 Oct 2024 18:01:15 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Evemose has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   address reviews
>
> test/langtools/tools/javac/sealed/PrivateMembersInPermitClause.java line 59:
> 
>> 57: 
>> 58:     @Test
>> 59:     public void givenPrivateClassInPermitsClause_whenCompiling_thenShouldCompile() throws Exception {
> 
> I would use shorter method names, you can probably add more details about what the test does using javadoc or an internal comment

it may be the way, but comments could become danglig over time, not sure if its the way. If I were writing with junit, I would use @DisplayName, not sure if there is something like this in jtreg. I will se what can be done though

> test/langtools/tools/javac/sealed/PrivateMembersInPermitClause.java line 146:
> 
>> 144: 
>> 145:     @Test
>> 146:     public void givenPrivateClassInPermitsClause_whenThanCompilingOtherClassThatReferencesPrivateClassInPermitsClause_thenShouldFail() throws Exception {
> 
> this one is failing for me too

It may be. I run heavy machine learning model on y pc right now, so i prefer to run tests using CI to not blow up my PC. I hope this doesnt bother anyone too much so I can figure out correct error messages that are expected in a few iterations.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20718#discussion_r1788116720
PR Review Comment: https://git.openjdk.org/jdk/pull/20718#discussion_r1788115036