RFR: 8341483: Clarify special case handling of Types.getArrayType [v2]

Joe Darcy darcy at openjdk.org
Fri Oct 4 19:27:17 UTC 2024


On Fri, 4 Oct 2024 18:18:38 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Respond to review feedback.
>
> src/java.compiler/share/classes/javax/lang/model/util/Types.java line 268:
> 
>> 266:      *          an array. All valid types are {@linkplain ReferenceType
>> 267:      *          reference types} or {@linkplain PrimitiveType primitive types}.
>> 268:      *          Invalid types include null, executable, package, module, and wildcard types.
> 
> Should it be somehow more clear that it's not `null`, but the __Null Type__. Maybe you can link to it as follows?
> 
>     {@linkplain NullType null}

> Should it be somehow more clear that it's not `null`, but the **Null Type**. Maybe you can link to it as follows?
> 
> ```
> {@linkplain NullType null}
> ```

Good suggestion; implemented.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21346#discussion_r1788210165


More information about the compiler-dev mailing list