RFR: 8337851: Some tests have name which confuse jtreg [v3]
Jonathan Gibbons
jjg at openjdk.org
Fri Oct 11 15:36:12 UTC 2024
On Tue, 27 Aug 2024 12:54:38 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> With my official `jtreg` hat on, I recommend always placing the `jtreg` tags immediately after any legal header comments and _before_ any and all of the source code that comprises the test.
>
>> With my official `jtreg` hat on, I recommend always placing the `jtreg` tags immediately after any legal header comments and _before_ any and all of the source code that comprises the test.
>
> @jonathan-gibbons Are there any disadvantages to placing jtreg tags right before the test class declaration, after all the import statements? It is more convenient when viewing test code in IDE: the jtreg tags are clearly visible. If the tags are after the legal header, they're collapsed together with the legal header (and imports).
There are no technical disadvantages, but I stand by my recommendation to place the test description before any Java code constructions like package, import or type declarations.
We should not change the prevailing style just because of some new prevailing behavior in any given IDE.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20475#discussion_r1797123563
More information about the compiler-dev
mailing list