RFR: 8335989: Implement Module Import Declarations (Second Preview) [v3]
Jan Lahoda
jlahoda at openjdk.org
Thu Oct 17 11:49:18 UTC 2024
On Thu, 17 Oct 2024 11:39:51 GMT, Aggelos Biboudis <abimpoudis at openjdk.org> wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 15 commits:
>>
>> - Merge branch 'master' into JDK-8335989
>> - Reflecting review feedback.
>> - Cleanup.
>> - Cleanup.
>> - Fixing tests
>> - Adding a separate scope for module imports.
>> - Cleanup.
>> - Make very sure java.base is completed.
>> - Keep jdk.internal.javac qualified export from java.base.
>> - Adding forgotten change.
>> - ... and 5 more: https://git.openjdk.org/jdk/compare/15815089...b5f9df2a
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/api/JavacScope.java line 159:
>
>> 157: enum ScopeType {
>> 158: ORDINARY,
>> 159: START_IMPORT,
>
> Is this a "start" import or a "star"* import? 🤔
Star import. Will fix.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21431#discussion_r1804617634
More information about the compiler-dev
mailing list