RFR: 8034066: Incorrect alignment in the "Code" section for "-c -XDdetails" options

[Jonathan Lampérth]

On Fri, 25 Oct 2024 02:55:51 GMT, Chen Liang <liach at openjdk.org> wrote:

>> test/langtools/tools/javap/8034066/T8034066.java line 37:
>> 
>>> 35: import java.util.regex.Pattern;
>>> 36: 
>>> 37: public class T8034066 {
>> 
>> Please don't continue the old practice of naming tests after their bug ID. It obfuscates which test class does what (both in the source code and in the test logs). Suggestion for name: `TestStackMapDetailsIndent`
>
> How about `CodeIndentTest`? We prefer to use prefix modifiers, and this tests the indent for general code writer output.

I would propose `ClassWriterCodeIndentTest`. Although a little longer, it makes clear we are testing the Path `ClassWriter->CoderWriter` and not the similar `AttributeWriter->CodeWriter` control flow. What do you think?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21685#discussion_r1816192328