RFR: 8341408: Implement JEP 488: Primitive Types in Patterns, instanceof, and switch (Second Preview) [v2]

[Aggelos Biboudis]

On Mon, 28 Oct 2024 14:46:14 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Aggelos Biboudis has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address review
>
> test/langtools/tools/javac/patterns/PrimitiveTypesInTestingContextErasure.java line 1:
> 
>> 1: import java.util.List;
> 
> nit: this import seems to be out of place

Also moved it. Thx!

> test/langtools/tools/javac/patterns/PrimitiveTypesInTestingContextErasure.java line 30:
> 
>> 28:  * @summary Compiler Implementation for Primitive types in patterns, instanceof, and switch (Second Preview)
>> 29:  * @enablePreview
>> 30:  * @compile PrimitiveTypesInTestingContextErasure.java
> 
> I don't think you need the `@compile` and the `@run` commands `@enablePreview` should be enough

Done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21539#discussion_r1819263030
PR Review Comment: https://git.openjdk.org/jdk/pull/21539#discussion_r1819262714