RFR: 8338981: Access to private classes should be permitted inside the permits clause of the enclosing top-level class [v18]

Evemose duke at openjdk.org
Tue Oct 29 14:50:51 UTC 2024


On Mon, 28 Oct 2024 18:13:47 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Evemose has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - remove trailing whitespaces
>>  - Merge remote-tracking branch 'origin/selaed-permits-allow-private-members' into selaed-permits-allow-private-members
>>  - address review comments
>
> test/langtools/tools/javac/sealed/PrivateMembersInPermitClause.java line 80:
> 
>> 78:      */
>> 79:     @Test
>> 80:     public void otherTopLevelPrivateClassFails() throws Exception {
> 
> this test is failing for me (Linux):
> 
> 
> Expected errors: [S.java:5:25: compiler.err.report.access: S.A, private, S, 1 error], 
> but got: [S.java:4:25: compiler.err.report.access: S.A, private, S, 1 error]

Thanks, I forgot to change the line number when removed empty line for jcheck

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20718#discussion_r1820953597


More information about the compiler-dev mailing list