RFR: 8341408: Implement JEP 488: Primitive Types in Patterns, instanceof, and switch (Second Preview) [v2]

Jan Lahoda jlahoda at openjdk.org
Tue Oct 29 16:14:15 UTC 2024


On Mon, 28 Oct 2024 15:24:22 GMT, Aggelos Biboudis <abimpoudis at openjdk.org> wrote:

>> This PR prepares the improvement for JEP 488.
>> 
>> The proposed approach is described in the CSR.
>> 
>> In terms of compiler implementation, we add the related translation in `TransPatterns`. Interestingly, this issue would be ideally addressed in `TransTypes`. However, there are some conveniences in `TransPatterns` that would need to be pulled into `TransTypes` to make this work: 1) the dependency to `makeBinary` and transitively to `operators` and 2) a lot of ceremony around `currentMethodSym` is already setup nicely in `TransPatterns`.
>
> Aggelos Biboudis has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address review

Looks good to me.

-------------

Marked as reviewed by jlahoda (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21539#pullrequestreview-2402446341


More information about the compiler-dev mailing list