RFR: 8335989: Implement Module Import Declarations (Second Preview) [v4]

Alan Bateman alanb at openjdk.org
Wed Oct 30 13:25:07 UTC 2024


On Wed, 30 Oct 2024 12:49:16 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

> Do I miss something?

Okay, so this must have been modified at some point to add/use isSupportedModuleDescriptorVersion, in which case readModuleAttribute won't be called. In that case, what you have is okay.

Minor nit, can you fix up the code style in the modified expression as it has ended up with && at the start and end of lines which looks a bit messy.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21431#discussion_r1822617486


More information about the compiler-dev mailing list