RFR: 8333427: langtools/tools/javac/newlines/NewLineTest.java is failing on Japanese Windows

[Jaikiran Pai]

On Mon, 26 Aug 2024 01:08:38 GMT, KIRIYAMA Takuya <duke at openjdk.org> wrote:

>> Hello @tkiriyama, sorry I hadn't paid attention to this PR. I will take a look soon.
>
> Hello @jaikiran,
> This is just a friendly reminder. How is the task going?

> I verified that this test code passed. If the test using only UTF-8 is sufficient, this seems to be the best fix.
> ...
> Should I ignore this concern and specify UTF-8 for the test?

Hello @tkiriyama, sorry it took me long to get back to this. I had forgotten what this PR was about. Having reviewed it again and going through the comments, it's good that the test now passes if you use UTF-8. As for whether or not that's OK to do in this specific test, I'm unsure. We will need someone from the compiler team who know more about this test to provide that input.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19519#discussion_r1745872643