RFR: 8336942: Improve test coverage for class loading elements with annotations of different retentions [v2]

[Vicente Romero]

On Tue, 13 Aug 2024 15:12:08 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote:

>> This changes adds some additional test coverage for the handling of type use annotations read from class files added in [JDK-8225377](https://bugs.openjdk.org/browse/JDK-8225377).
>> 
>> If both a `RUNTIME` and `CLASS` retention type annotation appear on the same element loaded from a class file, the annotations are attached by separate `TypeAnnotationCompleter's`s, and the logic in `ClassReader` needs to merge the annotations from the second attribute with annotations added by the first one.
>> 
>> The implementation already handles this correctly, but there isn't explicit test coverage for it. This change adds test coverage for that case.
>
> Liam Miller-Cushon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'master' into JDK-8336942
>  - Sort entries in nameToAnnotation
>  - 8336942: Improve test coverage for class loading elements with annotations of different retentions

Marked as reviewed by vromero (Reviewer).

looks good

-------------

PR Review: https://git.openjdk.org/jdk/pull/20287#pullrequestreview-2300596217
PR Comment: https://git.openjdk.org/jdk/pull/20287#issuecomment-2346535434