RFR: 8340024: In ClassReader, extract a constant for the superclass supertype_index
Liam Miller-Cushon
cushon at openjdk.org
Thu Sep 12 16:44:03 UTC 2024
On Thu, 12 Sep 2024 16:33:10 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote:
> Hi, please consider this cleanup to extract a literal to a documented constant in `ClassReader`, see [JDK-8340024](https://bugs.openjdk.org/browse/JDK-8340024).
I also noticed this constant shows up a couple times in `TypeAnnotationPosition`, I could also define a shared constant there and reference it in `ClassReader`:
https://github.com/openjdk/jdk/blob/ab9b72c50a5f324e53b8c6535f401cc185b98c75/src/jdk.compiler/share/classes/com/sun/tools/javac/code/TypeAnnotationPosition.java#L828
https://github.com/openjdk/jdk/blob/ab9b72c50a5f324e53b8c6535f401cc185b98c75/src/jdk.compiler/share/classes/com/sun/tools/javac/code/TypeAnnotationPosition.java#L796
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20970#issuecomment-2346773897
More information about the compiler-dev
mailing list