RFR: 8338981: Access to private classes should be permitted inside the permits clause of the enclosing top-level class [v2]

Evemose duke at openjdk.org
Thu Sep 12 22:59:08 UTC 2024


On Tue, 27 Aug 2024 09:16:32 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

>> Evemose has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   allowed non-direct members to be permitted
>
> Others may have a different opinion, but this seems a bit too hacky to me (given we would need to maintain this for a long time).
> 
> I would suggest to try to add a new flag into `AttrContext`, along the lines of `permitPrivateAccessInHeader`, and set it while attributing the permitted types. Not sure how invasive that'd be, but hopefully not terribly much. And it should be clear (and documented) what's happening.

@lahodaj could you review please?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20718#issuecomment-2347379043


More information about the compiler-dev mailing list