RFR: 8334248: Invalid error for early construction local class constructor method reference [v6]

Maurizio Cimadamore mcimadamore at openjdk.org
Thu Sep 26 08:41:38 UTC 2024


On Wed, 25 Sep 2024 14:35:03 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

>> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Tweak test and add positive test case
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java line 3785:
> 
>> 3783:      * Find a suitable reference to an enclosing 'A.this' such that A is a subclass of the provided class symbol.
>> 3784:      * Note that this method can match multiple times during the traversal, as multiple enclosing classes can
>> 3785:      * be a subclasses of the provided class. Therefore, if this method finds a matching 'A.this' that cannot be accessed
> 
> This comment needs updating to reflect the new logic (i.e., stopping now at the first class found).

Good catch!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19904#discussion_r1776635186


More information about the compiler-dev mailing list