RFR: 8344708: Compiler Implementation of Module Import Declarations [v3]

[Vicente Romero]

On Mon, 31 Mar 2025 17:40:25 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

>> This is a patch to finalize the module imports feature. Please see:
>> https://bugs.openjdk.org/browse/JDK-8344700
>
> Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixing test.

src/jdk.jshell/share/classes/jdk/internal/jshell/tool/Startup.java line 340:

> 338:      */
> 339:     static Startup defaultStartup(int sourceLevel, boolean preview, MessageHandler mh) {
> 340:         boolean startup24 = sourceLevel < 25;

should we use a constant here?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23801#discussion_r2025076240