RFR: 8344706: Compiler Implementation of Compact Source Files and Instance Main Methods

Chen Liang liach at openjdk.org
Mon Apr 7 07:01:35 UTC 2025


On Fri, 4 Apr 2025 07:20:23 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

> This is a PR that implements JEP: Compact Source Files and Instance Main Methods. Changes include:
> - `java.io.IO` moved to `java.lang.IO`, and no longer uses `System.console()` to implement the methods (thanks to @stuart-marks)
> - `java. ... .IO` is no longer automatically imported in any compilation unit
> - the feature is finalized (i.e. no longer requires `--enable-preview`)

src/java.base/share/classes/java/lang/IO.java line 183:

> 181:      * @return the internal BufferedReader instance
> 182:      */
> 183:     static synchronized BufferedReader reader() {

Is the lock only inteneded for initialization, i.e. should it apply for simply getting the reader?

test/jdk/java/io/IO/IO.java line 1:

> 1: /*

Shouldn't the package of this test be moved to java/lang?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24438#discussion_r2029576244
PR Review Comment: https://git.openjdk.org/jdk/pull/24438#discussion_r2029576615


More information about the compiler-dev mailing list