Integrated: 8353757: Log class should have a proper clear() method

Archie Cobbs acobbs at openjdk.org
Tue Apr 8 20:07:24 UTC 2025


On Fri, 4 Apr 2025 22:05:58 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

> This is a simple refactoring to add a method `Log.clear()`, move `ReusableLog.clear()`'s clearing operations into it and invoke `super.clear()` instead, and add two more fields that should be included in the clear operation but were not because they were added to `Log` after `ReusableLog.clear()` was added and were missed.
> 
> A natural question: Are there any other fields in `Log` that should be cleared in `Log.clear()`? The two I've added (`nsuppressederrors` and `nsuppressedwarns`) are the only two that weren't there when `ReusableLog` as added, so presumably not, but it's possible.

This pull request has now been integrated.

Changeset: 5b42c46b
Author:    Archie Cobbs <acobbs at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/5b42c46b48363acd00ee4a183edca9a48cdc16c8
Stats:     21 lines in 2 files changed: 14 ins; 2 del; 5 mod

8353757: Log class should have a proper clear() method

Reviewed-by: vromero, mcimadamore

-------------

PR: https://git.openjdk.org/jdk/pull/24460


More information about the compiler-dev mailing list