RFR: 8352748: Remove com.sun.tools.classfile from the JDK [v2]
Jan Lahoda
jlahoda at openjdk.org
Wed Apr 9 15:17:33 UTC 2025
On Wed, 9 Apr 2025 15:04:24 GMT, Chen Liang <liach at openjdk.org> wrote:
>> With all dependencies of com.sun.tools.classfile in the JDK converted to the ClassFile API, we can remove this legacy library for release 25 like how we removed ASM.
>>
>> Testing: built locally, running tier 1-3 tests
>>
>> Don't know why, but GitHub is redundantly displaying changes that are already in #24212.
>
> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits:
>
> - Merge branch 'master' of https://github.com/openjdk/jdk into feature/remove-old-classfile
> - 8352748: Remove com.sun.tools.classfile from the JDK
> - Merge branch 'master' of https://github.com/openjdk/jdk into feature/remove-old-classfile
> - Merge branch 'master' of https://github.com/openjdk/jdk into feature/migrate-create-symbols
> - Other references to remove
> - Merge branch 'master' of https://github.com/openjdk/jdk into feature/migrate-create-symbols
> - FieldDescription.constantValue uses Integer for byte and short
> - 8310310: Migrate CreateSymbols tool in make/langtools to Classfile API
Looks good to me. I won't increase the reviewer count, but please wait a few days to give others chance to comment if they choose to.
-------------
Marked as reviewed by jlahoda (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24528#pullrequestreview-2753858690
More information about the compiler-dev
mailing list