RFR: 8352642: Set zipinfo-time=false when constructing zipfs FileSystem in com.sun.tools.javac.file.JavacFileManager$ArchiveContainer for better performance [v2]

Jason Zaugg jzaugg at openjdk.org
Sun Apr 20 13:01:30 UTC 2025


On Tue, 8 Apr 2025 09:22:32 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> src/jdk.compiler/share/classes/com/sun/tools/javac/file/JavacFileManager.java line 581:
>> 
>>> 579:                 // Less common case is possible if the file manager was not initialized in JavacTask,
>>> 580:                 // or if non "*.jar" files are on the classpath. At the time of writing, both `javac -cp a.zip`
>>> 581:                 // and `javac -cp x.JAR` file would hit this branch which may warrant investigation.
>> 
>> Hello Jason, do we need that second sentence to be added as a code comment? I feel it creates confusion on what's expected to be done. Perhaps just add that first sentence and remove the second?
>
> Could you also update the copyright year on this file from 2024 to 2025?

All done now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24176#discussion_r2051718910


More information about the compiler-dev mailing list