RFR: 8355065: ConcurrentModificationException in RichDiagnosticFormatter [v2]

[Liam Miller-Cushon]

> Hi, please consider this fix for [JDK-8355065](https://bugs.openjdk.org/browse/JDK-8355065). RichDiagnosticFormatter is comparing type variables by their `toString` representation, and in this example the comparison fails due to type annotations. Replacing a call to `stripMetadataIfNeeded` with `stripMetadata` allows the comparison to succeed, and is consistent with the approach used in other parts of RichDiagnosticFormatter (e.g. for [the fix for JDK-8144580](https://github.com/openjdk/jdk/commit/570883e4dc5f769e17b3fcd8f2bbeb369dfe3a5d)).

Liam Miller-Cushon has updated the pull request incrementally with one additional commit since the last revision:

  Detect recursion in RichDiagnosticFormatter#format
  
  The class is not designed to be re-entered, and will produce incorrect
  results if that happens.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/24769/files
  - new: https://git.openjdk.org/jdk/pull/24769/files/f9eaa00c..1a1ff0bf

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=24769&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=24769&range=00-01

  Stats: 58 lines in 1 file changed: 36 ins; 4 del; 18 mod
  Patch: https://git.openjdk.org/jdk/pull/24769.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/24769/head:pull/24769

PR: https://git.openjdk.org/jdk/pull/24769