RFR: 8346785: Potential infinite loop in JavadocTokenizer.ensures [v2]

[Nizar Benalla]

On Thu, 24 Apr 2025 15:05:50 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:

>> Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - respond to feedback -- keep int[] instead of Arraylist and add check for grow <= 0
>>  - Merge branch 'master' into jd-ensure
>>  - fix JdT.ensure
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavadocTokenizer.java line 313:
> 
>> 311: 
>> 312:             if (grow <= 0) {
>> 313:                 throw new IndexOutOfBoundsException();
> 
> This check needs to be inside the `while` loop (see bug description).

Thanks Hannes, fixed in [88a5f49](https://github.com/openjdk/jdk/pull/24620/commits/88a5f499a32e89f1f0027058c270742243dcda85).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24620#discussion_r2058704061