RFR: 8174840: Elements.overrides does not check the return type of the methods [v3]
Chen Liang
liach at openjdk.org
Fri Apr 25 14:56:57 UTC 2025
On Fri, 28 Mar 2025 01:59:26 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:
>> Please review this PR to clarify the documentation of `Elements.overrides` through an `@apiNote`, this PR is essentially a doc-only change. This PR supersedes https://github.com/openjdk/jdk/pull/22244.
>>
>> TIA.
>
> Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains nine additional commits since the last revision:
>
> - feedback: improve api note to convey more context
> - Merge branch 'master' into elements-api-note
> - whitespace
> - Update according to review comments.
> - Merge remote-tracking branch 'upstream/master' into elements-api-note
> - Respond to feedback around the wording.
> - Respond to feedback. Using Jan's comment to not imply particular requirement on the implementation.
> - (C) 2025
> - Initial commit obtained from a cherry pick/squash of a now superseded PR.
These update notes look good.
-------------
Marked as reviewed by liach (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22920#pullrequestreview-2794416797
More information about the compiler-dev
mailing list