RFR: 8355956: Prepare javap for class file format aware access flag parsing [v2]
Vicente Romero
vromero at openjdk.org
Wed Apr 30 21:31:45 UTC 2025
On Wed, 30 Apr 2025 18:03:29 GMT, Chen Liang <liach at openjdk.org> wrote:
>> A prerequisite to #24760; this was part of it, but was split out to simplify the review of the addition of `maskToAccessFlags(int, Location, CFFV)` by minimizing the changes in javap. That patch will only need to update `BasicWriter` as a result.
>>
>> Testing: langtools/tools/javap, tier 1+2 underway
>
> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>
> - Adapt the location APIs
> - Merge branch 'master' of https://github.com/openjdk/jdk into fix/javap-cffv-access-flags
> - 8355956: Prepare javap for class file format aware access flag parsing
lgtm
-------------
Marked as reviewed by vromero (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24955#pullrequestreview-2808494323
More information about the compiler-dev
mailing list