Compiler PR review requests

[Archie Cobbs]

Hi Chen,

Thanks for responding. I understand, and there's absolutely no hurry on
these. I'm just trying to keep them from falling into the "lost forever"
bucket.

I'm targeting smaller, lower priority fixes, minor improvements, and
cleanups that other people are too busy to deal with ("code janitor"), so
it's understood that these PR's are going to be inherently less exciting
and lower priority in general. That also means sending out occasional (and
hopefully non-annoying) pings for review, which I don't mind doing, but let
me know if the ping rate needs to be adjusted :)

-Archie

On Tue, Aug 12, 2025 at 10:13 AM Chen Liang <chen.l.liang at oracle.com> wrote:

> Hi Archie, FYI people are coming back from JVMLS so it may take some time.
> In addition, most of our new development are focused on experimental
> projects like Babylon, Valhalla, and Amber, and javac is mainly just
> routine bugfixes, so these did not catch people's attention. So I think
> 8359383 is the most likely to be prioritized being a fix, while 8353487 is
> less because it involves API additions that has not seen a usage request.
>
> Thanks, Chen
> ------------------------------
> *From:* compiler-dev <compiler-dev-retn at openjdk.org> on behalf of Archie
> Cobbs <archie.cobbs at gmail.com>
> *Sent:* Monday, August 11, 2025 11:57 AM
> *To:* compiler-dev <compiler-dev at openjdk.org>
> *Subject:* Compiler PR review requests
>
> Dear compiler-dev reviewers,
>
> I have a few small PR's and one big PR that need reviewers and would
> appreciate your help in getting these resolved.
>
> The big one...
>
> JDK-8348611: Eliminate DeferredLintHandler and emit warnings after
> attribution <https://github.com/openjdk/jdk/pull/24584>
>
> This is a refactoring/cleanup that simplifies how warnings are logged, so
> that regardless of compiler phase, lint configuration, etc., you can always
> just invoke log.warning() to log a warning and the right thing happens
> automatically.
>
> Already reviewed by Maurizio but needs a second reviewer.
>
> The small ones...
>
> JDK-8349847: Support configuring individual lint categories as errors
> <https://github.com/openjdk/jdk/pull/23622>
>
> Adds the capability for more precise control of which warnings cause an
> error. For example, -Werror:all,-serial.
>
> This one has been sitting out there with a CSR since February. The code is
> fairly straightforward; I think the main question is whether this is
> something we want to add or not.
>
> Any strong opinions one way or the other?
>
> JDK-8353487: JShell LocalExecutionControl should allow decorating the
> execution task <https://github.com/openjdk/jdk/pull/24398>
>
> This is a simple API addition, but there is unresolved discussion about
> the best way to augment the API.
>
> Need someone in a position of authority (Jan) to weigh in.
>
> JDK-8359383 <https://bugs.openjdk.org/browse/JDK-8359383>: Incorrect
> starting positions for implicitly typed variables
> <https://github.com/openjdk/jdk/pull/25786>
>
> This fixes a few minor and obscure glitches in computed lexical starting
> positions. Not the most important problem in the world right now, but it
> would be nice to fix these corner cases.
>
> Thanks,
> -Archie
>
> --
> Archie L. Cobbs
>


-- 
Archie L. Cobbs
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/compiler-dev/attachments/20250812/a08de909/attachment-0001.htm>