RFR: 8365060: Historical data for JDK 8 should include the jdk.net package

[Chen Liang]

On Mon, 18 Aug 2025 08:18:04 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

> In JDK 8, the package `jdk.net` was exported and part of `rt.jar`, and hence should have been part of the historical data for `--release`, but it is not. The primary goal of this PR is to add historical data for `jdk.net` for JDK 8.
> 
> The changes herein are based on JDK 8u462. I used the Probe running on JDK 8 to dump the classfiles, along these lines:
> 
> $ java -classpath .../make/langtools/src/classes/ build.tools.symbolgenerator.Probe /tmp/jdk8-classfiles
> 
> 
> and then the up-to-date `CreateSymbols` to generate the `sym.txt` files, along these lines:
> 
> java --add-exports jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED  CreateSymbols.java build-description-incremental-file .../src/jdk.compiler/share/data/symbols/symbols .../src/jdk.compiler/share/data/symbols/include.list 8 /tmp/jdk8-classfiles '<none>' --normalize-method-flags
> 
> 
> There are a few APIs that have been added for this release, and a few representational changes.
> 
> Most notably - the ordering of "removal" entries (i.e. those that start with `-`) and "add" entries is much more strict in the current `CreateSymbols`, and so there are some changes where the removal entries are moved to the front. I went through those, and they seem OK to me.
> 
> I'll add specific comments to the other updates to the files.

Marked as reviewed by liach (Reviewer).

test/langtools/tools/javac/sym/ElementStructureTest.java line 286:

> 284:                 JavaFileObject file = new ByteArrayJavaFileObject(data.toByteArray());
> 285:                 try (InputStream in = new ByteArrayInputStream(data.toByteArray())) {
> 286:                     String name = ClassFile.of().parse(in.readAllBytes()).thisClass().name().stringValue().replace("/", ".");

Good fix for `lastIndexOf('.')` below 👍

-------------

PR Review: https://git.openjdk.org/jdk/pull/26817#pullrequestreview-3128945581
PR Review Comment: https://git.openjdk.org/jdk/pull/26817#discussion_r2282796156