RFR: 8365878: jshell TOOLING's javap should use binary names [v2]

altrisi duke at openjdk.org
Thu Aug 21 17:30:46 UTC 2025


> This PR makes TOOLING.jsh's `javap` function support anonymous, local and built-in nested classes.
> 
> Note that nested classes created in jshell would previously work, but not JDK ones as they'd miss the is built-in check (wrong name for `Class.forName`) and later throw an exception because of a null classloader.
> 
> The rest of classes would fail the canonical name check, which wouldn't allow them to be disassembled.
> 
> This change makes them work by changing the check from canonicalName != null to specific checks for unsupported types of classes, and doing Class.forName using the result of getName(), not the canonical name, for the built-in check.

altrisi has updated the pull request incrementally with one additional commit since the last revision:

  Update copyright and add this bug id to ToolingTest

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/26864/files
  - new: https://git.openjdk.org/jdk/pull/26864/files/977c73cb..4077f403

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=26864&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=26864&range=00-01

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/26864.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/26864/head:pull/26864

PR: https://git.openjdk.org/jdk/pull/26864


More information about the compiler-dev mailing list