RFR: 8373436: Cleanup JRTIndex usages [v2]

[Jan Lahoda]

On Thu, 11 Dec 2025 10:04:37 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Cleanup: JRTIndex implements LegacyCtPropertiesAccess directly, as suggested.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/file/JavacFileManager.java line 466:
> 
>> 464:                 private final JRTIndex jrtIndex = getJRTIndex();
>> 465:                 @Override
>> 466:                 public boolean supportsLegacyFlags(JavaFileObject fo) {
> 
> Question (possibly naive) -- couldn't `LegacyCtProperties` access be an interface that is implemented directly by `JRTIndex` ? Then this method could return the jrtIndex -- and that would also be a `LegacyCtPropertiesAccess`. You still achieve the separation you are aiming for, but a bit more directly?

Yes, I think that's doable. Thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28761#discussion_r2610041280