Integrated: 8326485: Assertion due to Type.addMetadata adding annotations to already-annotated type

[Aggelos Biboudis]

On Thu, 23 Jan 2025 16:17:45 GMT, Aggelos Biboudis <abimpoudis at openjdk.org> wrote:

> We end up with an errorType having annotation metadata (which subsequently results in this assertion getting invalidated after `Type ret = typeWithAnnotations(type, enclTy, annotations);` is executed).
> 
> What if we continue to try to define the `enclTy` (iteratively)? The error can still be reported appropriately. If this PR is merged it reproduces the original test case by running as expected: many errors without a crash:
> 
> 
> javac src/main/java/net/ccbluex/liquidbounce/injection/mixins/minecraft/gui/MixinChatInputSuggestor.java -cp /tmp/jars/annotations-20.1.0.jar:/tmp/jars/kotlin-compiler-embeddable-1.9.0.jar
> 
> 
> WDYT?

This pull request has now been integrated.

Changeset: 9aa6d09b
Author:    Aggelos Biboudis <abimpoudis at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/9aa6d09bf74110bf4f5756d7c3b106558042102f
Stats:     44 lines in 3 files changed: 42 ins; 1 del; 1 mod

8326485: Assertion due to Type.addMetadata adding annotations to already-annotated type

Reviewed-by: jlahoda

-------------

PR: https://git.openjdk.org/jdk/pull/23272