RFR: 8347958: Minor compiler cleanups relating to MandatoryWarningHandler [v3]

Maurizio Cimadamore mcimadamore at openjdk.org
Wed Feb 5 22:09:11 UTC 2025


On Wed, 5 Feb 2025 16:21:37 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

>> After recent improvements to Lint-related classes, there are now a few minor cleanup opportunities relating to `MandatoryWarningHandler`.
>> 
>> 1. The new `LintWarning` class provides access to the associated `LintCategory`. This means that the `LintCategory` parameter being passed to the `MandatoryWarningHandler` constructor is no longer needed.
>> 1. The `prefix` string being passed to the `MandatoryWarningHandler` constructor can (in most cases) be inferred as well.
>> 1. The field `Check.sunApiHandler` (which has type `MandatoryWarningHandler`) is no longer used and can be removed.
>
> Archie Cobbs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Restore the explicit LintCategory constructor parameter.

Thanks for fixing!

-------------

Marked as reviewed by mcimadamore (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23167#pullrequestreview-2597086741


More information about the compiler-dev mailing list