RFR: 8347958: Minor compiler cleanups relating to MandatoryWarningHandler [v2]
Maurizio Cimadamore
mcimadamore at openjdk.org
Wed Feb 5 22:09:12 UTC 2025
On Wed, 5 Feb 2025 16:18:50 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:
> Admittedly it was a close call - the benefit being the elimination of an instance field and constructor parameter.
To clarify my thought process a bit: while the change made the impl simpler (one less field, one less constructor parameter) it also made it more "magic", in the sense that we lost the hard constraint that a MWH can only refer to _one_ lint category. So, overall, at least in my eyes, the overall balance was negative.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23167#discussion_r1943737457
More information about the compiler-dev
mailing list