RFR: 8349058: 'internal proprietary API' warnings make javac warnings unusable [v2]

Thu Feb 6 15:07:16 UTC 2025

On Wed, 5 Feb 2025 18:34:26 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote:

>> This change is a partial backout of [JDK-8332744](https://bugs.openjdk.org/browse/JDK-8332744). The logic was reverted, but the test was preserved and updated to reflect the updated behaviour, and some cleanups to benchmark code were kept.
>> 
>> This restores the ability to use `-XDignore.symbol.file` as an ad-hoc suppression mechanism for `sunapi` diagnostics, see discussion in [JDK-8349058](https://bugs.openjdk.org/browse/JDK-8349058).
>
> Liam Miller-Cushon has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Improvements to test

lgtm, thanks!

-------------

Marked as reviewed by vromero (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23448#pullrequestreview-2598955464