RFR: 8349991: GraphUtils.java can use String.replace() instead of String.replaceAll()
Florent Guillaume
duke at openjdk.org
Mon Feb 24 14:13:55 UTC 2025
On Mon, 24 Feb 2025 11:46:33 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
>> I know that javac only ever uses two properties at most... but this class is rather general, and the proposed change would introduce subtle bugs if a third property is ever added to inference nodes -- or any other node using in javac implementation
>
> (separately, I'm also curious of when such a change makes a real impact -- `toDot()` is mostly used when debugging... but I'm ok with replacing complex methods with simpler forms -- where possible)
But `replace` replaces all occurrences already.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23658#discussion_r1967713977
More information about the compiler-dev
mailing list