RFR: 8344148: Add an explicit compiler phase for warning generation [v3]

Archie Cobbs acobbs at openjdk.org
Thu Jan 2 19:17:54 UTC 2025


> Please review this patch which does some minor refactoring to the compiler:
> * Create a new `WARN` phase which can be a dedicated home for (new) lint/warning logic
> * Create a new `WarningAnalyzer` singleton whose job is to invoke such lint/warning logic
> * Move `ThisEscapeAnalyzer` out of `Flow` (where it doesn't belong) and into `WarningAnalyzer`
> * Refactor `ThisEscapeAnalyzer` to be a context singleton like all other such classes
> 
> See [JDK-8344148](https://bugs.openjdk.org/browse/JDK-8344148) for details.

Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:

 - Bump copyright year to 2025.
 - Merge branch 'master' into JDK-8344148
 - Merge branch 'master' into JDK-8344148
 - Merge branch 'master' into JDK-8344148
 - Update copyright years.
 - Add an explicit compiler phase for warning generation.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22088/files
  - new: https://git.openjdk.org/jdk/pull/22088/files/b1ca46d9..03f67319

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22088&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22088&range=01-02

  Stats: 16289 lines in 412 files changed: 12651 ins; 2312 del; 1326 mod
  Patch: https://git.openjdk.org/jdk/pull/22088.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22088/head:pull/22088

PR: https://git.openjdk.org/jdk/pull/22088


More information about the compiler-dev mailing list